Skip to content

branch-3.0: [chore](file_cache) Set enbale_dump_error_file to false by default #47229 #47250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jan 22, 2025
Merged

branch-3.0: [chore](file_cache) Set enbale_dump_error_file to false by default #47229 #47250

dataroaring merged 1 commit into from
Jan 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 20, 2025

Cherry-picked from #47229

@github-actions github-actions bot requested a review from dataroaring as a code owner January 20, 2025 08:32
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 20, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 20, 2025

TPC-H: Total hot run time: 41176 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3cbf6abd0140b770fefb58ace3e1c99da4d23c1, data reload: false

------ Round 1 ----------------------------------
q1	17566	7329	7328	7328
q2	2488	172	163	163
q3	11577	1157	1170	1157
q4	10334	826	807	807
q5	8334	2917	2897	2897
q6	236	150	151	150
q7	978	619	608	608
q8	9807	2016	2069	2016
q9	6786	6486	6393	6393
q10	6935	2316	2295	2295
q11	452	267	265	265
q12	398	221	208	208
q13	17778	3038	2974	2974
q14	232	204	210	204
q15	554	514	535	514
q16	674	645	614	614
q17	975	560	553	553
q18	7359	6614	6675	6614
q19	1437	1106	1052	1052
q20	476	211	193	193
q21	3963	3213	3184	3184
q22	1100	987	1003	987
Total cold run time: 110439 ms
Total hot run time: 41176 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7345	7210	7192	7192
q2	325	227	242	227
q3	3067	3014	3017	3014
q4	2098	1809	1816	1809
q5	5651	5743	5712	5712
q6	223	137	141	137
q7	2173	1839	1830	1830
q8	3322	3470	3472	3470
q9	8904	8885	8807	8807
q10	3611	3558	3550	3550
q11	588	485	498	485
q12	848	604	587	587
q13	3886	3143	3205	3143
q14	318	279	286	279
q15	592	531	542	531
q16	706	687	667	667
q17	1812	1583	1597	1583
q18	8244	7926	7571	7571
q19	1742	1393	1384	1384
q20	2045	1807	1826	1807
q21	5225	5186	5188	5186
q22	1096	997	974	974
Total cold run time: 63821 ms
Total hot run time: 59945 ms

@doris-robot
Copy link

doris-robot commented Jan 20, 2025

TPC-DS: Total hot run time: 191364 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3cbf6abd0140b770fefb58ace3e1c99da4d23c1, data reload: false

query1	979	371	352	352
query2	6520	2089	2029	2029
query3	6705	215	218	215
query4	34043	23619	23490	23490
query5	4313	467	444	444
query6	275	172	170	170
query7	4619	310	314	310
query8	286	219	222	219
query9	9766	2680	2664	2664
query10	482	268	250	250
query11	17980	15128	15229	15128
query12	152	100	104	100
query13	1643	430	430	430
query14	9467	7302	6706	6706
query15	257	177	180	177
query16	8135	476	458	458
query17	1628	585	570	570
query18	2143	337	308	308
query19	371	157	157	157
query20	117	114	108	108
query21	210	105	102	102
query22	4542	4403	4358	4358
query23	34703	34045	33823	33823
query24	11218	2832	2872	2832
query25	684	423	413	413
query26	1248	171	168	168
query27	2884	350	348	348
query28	7981	2415	2457	2415
query29	942	473	456	456
query30	344	168	169	168
query31	1432	779	810	779
query32	100	61	59	59
query33	789	310	326	310
query34	917	490	516	490
query35	935	717	714	714
query36	1117	931	973	931
query37	144	85	75	75
query38	4218	3886	3864	3864
query39	1489	1468	1439	1439
query40	205	105	103	103
query41	55	52	52	52
query42	117	105	101	101
query43	525	481	485	481
query44	1269	804	810	804
query45	186	172	173	172
query46	1158	724	718	718
query47	1941	1854	1836	1836
query48	476	372	378	372
query49	1201	414	414	414
query50	848	410	419	410
query51	7446	7179	7176	7176
query52	104	95	94	94
query53	256	185	187	185
query54	1305	470	466	466
query55	82	76	83	76
query56	274	263	275	263
query57	1223	1103	1119	1103
query58	243	217	227	217
query59	3204	3048	2975	2975
query60	295	253	254	253
query61	116	112	110	110
query62	891	690	691	690
query63	221	190	183	183
query64	5332	685	638	638
query65	3292	3193	3186	3186
query66	1468	306	318	306
query67	15774	15703	15578	15578
query68	4895	573	579	573
query69	449	266	274	266
query70	1182	1129	1039	1039
query71	337	256	258	256
query72	6455	4053	3988	3988
query73	762	343	352	343
query74	10388	8951	8926	8926
query75	3399	2661	2646	2646
query76	3022	1048	1005	1005
query77	447	273	276	273
query78	10577	9669	9595	9595
query79	1231	602	592	592
query80	1039	438	425	425
query81	545	242	241	241
query82	1266	120	118	118
query83	215	147	152	147
query84	235	75	78	75
query85	1278	308	288	288
query86	369	296	267	267
query87	4431	4247	4248	4247
query88	3471	2408	2367	2367
query89	405	291	292	291
query90	1971	186	187	186
query91	189	148	167	148
query92	57	49	52	49
query93	1061	545	536	536
query94	894	288	285	285
query95	356	254	250	250
query96	603	279	279	279
query97	3324	3206	3201	3201
query98	221	203	203	203
query99	1519	1309	1268	1268
Total cold run time: 301878 ms
Total hot run time: 191364 ms

@doris-robot
Copy link

doris-robot commented Jan 20, 2025

ClickBench: Total hot run time: 33.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3cbf6abd0140b770fefb58ace3e1c99da4d23c1, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.10
query5	0.50	0.51	0.50
query6	1.13	0.73	0.74
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.50	0.51
query10	0.54	0.56	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.61	0.60
query14	2.96	3.12	2.96
query15	0.89	0.81	0.82
query16	0.38	0.37	0.39
query17	1.01	1.05	1.05
query18	0.24	0.23	0.21
query19	1.95	1.91	1.96
query20	0.01	0.02	0.01
query21	15.37	0.60	0.59
query22	2.56	2.37	1.72
query23	17.18	0.98	0.85
query24	2.98	1.70	1.10
query25	0.27	0.09	0.30
query26	0.32	0.14	0.13
query27	0.05	0.03	0.03
query28	9.90	1.12	1.07
query29	12.59	3.31	3.28
query30	0.24	0.06	0.07
query31	2.86	0.39	0.39
query32	3.25	0.47	0.45
query33	3.02	3.01	3.06
query34	16.81	4.46	4.50
query35	4.56	4.49	4.54
query36	0.66	0.48	0.52
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.19 s
Total hot run time: 33.2 s

@dataroaring dataroaring merged commit 822c132 into branch-3.0 Jan 22, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-47229-branch-3.0 branch January 22, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @gavinchou